lucasbru commented on code in PR #23761:
URL: https://github.com/apache/kafka/pull/23761#discussion_r4246753812
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/AssignmentRefiner.java:
##########
@@ -69,6 +69,13 @@ public interface AssignmentRefiner {
* The latest changelog offsets/end-offsets reported by the members
via heartbeats, from which the lag
* of a warm-up task is derived. Not populated for a member that
has not reported any offsets yet, for
* example right after a coordinator failover.
+ * @param heartbeatVersions
Review Comment:
I considered just passing into this only an enum "warmupSupport" but we may
want to reuse this in the future for enabling / disabling support for other
features. So I think passing around the RPC versions directly makes sense here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
