gaurav-narula commented on code in PR #23782:
URL: https://github.com/apache/kafka/pull/23782#discussion_r4247341905
##########
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##########
@@ -215,6 +215,13 @@ public class TopicConfig {
"thread to trigger election periodically (default is 5 minutes).
Please run <code>kafka-leader-election.sh</code> with <code>unclean</code>
option " +
"to trigger the unclean leader election immediately if needed.</p>";
+ public static final String MIRROR_UNCLEAN_LEADER_ELECTION_ENABLE_CONFIG =
"mirror.unclean.leader.election.enable";
Review Comment:
I think this should probably be excluded in MM2's
`DefaultConfigPropertyFilter`?
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##########
@@ -254,6 +254,8 @@ public String getConfigValue(ConfigKey key, String
headerName) {
ThrottledReplicaListValidator.INSTANCE, MEDIUM,
QuotaConfig.FOLLOWER_REPLICATION_THROTTLED_REPLICAS_DOC)
.defineInternal(QuotaConfig.MIRROR_REPLICATION_THROTTLED_REPLICAS_CONFIG, LIST,
QuotaConfig.MIRROR_REPLICATION_THROTTLED_REPLICAS_DEFAULT,
ThrottledReplicaListValidator.INSTANCE, MEDIUM,
QuotaConfig.MIRROR_REPLICATION_THROTTLED_REPLICAS_DOC)
+
.defineInternal(TopicConfig.MIRROR_UNCLEAN_LEADER_ELECTION_ENABLE_CONFIG,
BOOLEAN, false,
Review Comment:
Perhaps the default `false` here should be a constant
##########
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##########
@@ -215,6 +215,13 @@ public class TopicConfig {
"thread to trigger election periodically (default is 5 minutes).
Please run <code>kafka-leader-election.sh</code> with <code>unclean</code>
option " +
"to trigger the unclean leader election immediately if needed.</p>";
+ public static final String MIRROR_UNCLEAN_LEADER_ELECTION_ENABLE_CONFIG =
"mirror.unclean.leader.election.enable";
+ public static final String MIRROR_UNCLEAN_LEADER_ELECTION_ENABLE_DOC =
"When enabled, this property allows the mirror to support " +
+ "unclean leader elections. During log truncation, it forces the mirror
to wait for all assigned replicas, not just active ISR " +
Review Comment:
```suggestion
"unclean leader elections on the source cluster. During log
truncation, it forces the mirror to wait for all assigned replicas, not just
active ISR " +
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
