Ayoubhm07 opened a new pull request, #23786:
URL: https://github.com/apache/kafka/pull/23786
`build.gradle` declares three `testImplementation` dependencies twice inside
the same `dependencies` block:
| project | declaration | lines |
|---|---|---|
| `core` | `libs.apachedsCoreApi` | 1221 and 1230 |
| `connect:runtime` | `project(':server-common')` | 3842 and 3847 |
| `connect:runtime` | `project(':server')` | 3840 and 3848 |
Gradle resolves a configuration as a set, so the second declaration of each
is a no-op. I verified that by
comparing the resolved graph before and after on both configurations of both
projects:
```
./gradlew :connect:runtime:dependencies --configuration testCompileClasspath
./gradlew :connect:runtime:dependencies --configuration testRuntimeClasspath
./gradlew :core:dependencies --configuration testCompileClasspath
./gradlew :core:dependencies --configuration testRuntimeClasspath
```
The four reports are byte-identical before and after, at 241, 418, 498 and
760 lines, and the resolved module
sets match exactly at 73, 104, 125 and 171 modules.
In each pair I removed the later declaration rather than the earlier one,
which matters more than it looks.
Dropping `core` line 1221 instead of 1230 moves `apachedsCoreApi` behind
`libs.apacheda` in declaration
order, and the `:core:dependencies` report then lists
`org.apache.directory.api:api-all` before
`org.apache.directory.server:apacheds-core-api` where it used to come after.
Removing the later line keeps
every declaration position, and therefore the classpath order, exactly as it
is today.
`:core:testClasses` and `:connect:runtime:testClasses` compile,
`:core:check` and `:connect:runtime:check`
with `-x test` pass, which covers checkstyle, spotbugs and spotless for both
modules, and `rat` passes at the
root. As a spot check on the `connect:runtime` side I also ran `WorkerTest`:
140 tests, no failures.
Same cleanup as #23745 and #22868.
Co-Authored-By: Claude Opus 5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
