Copilot commented on code in PR #23784:
URL: https://github.com/apache/kafka/pull/23784#discussion_r4249675361
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/AssignmentRefinerImpl.java:
##########
@@ -237,12 +238,19 @@ static Map<String, ProcessLoad> indexProcessLoad(
*
* <p>Only an active-running or caught-up copy is ever promoted.
*
+ * <p>A task whose target owner is {@link WarmupSupport#NOT_SUPPORTED} is
never staged: its target owner never
+ * reports its restore progress, so no warm-up task could ever be seen to
complete the migration.
+ *
* @param currentAssignment
* The indexed current assignment, from {@link
#indexCurrentAssignment}.
* @param targetAssignment
* All members' target assignments, as computed by the task
assignor.
* @param members
* All members of the group, used to resolve which process a member
runs in.
+ * @param warmupSupport
+ * Whether each member may be handed a warm-up task.
+ * @param heartbeatVersions
+ * The version of the latest heartbeat of each member, which tells
whether a member can be warmed up.
Review Comment:
This `@param` documents `warmupSupport`, but `analyzeTasks` has no parameter
by that name. Javadoc reports unmatched parameter tags; keep only the
`heartbeatVersions` entry.
This issue also appears on line 317 of the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
