AndrewJSchofield commented on code in PR #23108:
URL: https://github.com/apache/kafka/pull/23108#discussion_r4246966142
##########
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerPollTest.java:
##########
Review Comment:
`rebalanceConsumer.position(tp)`?
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##########
@@ -644,21 +646,22 @@ public void testCommitInRebalanceCallback() {
completeCommitSyncApplicationEventSuccessfully();
final AtomicBoolean callbackExecuted = new AtomicBoolean(false);
- ConsumerRebalanceListener listener = new ConsumerRebalanceListener() {
+ RebalanceListener listener = new RebalanceListener() {
@Override
- public void onPartitionsRevoked(final Collection<TopicPartition>
partitions) {
+ public void onPartitionsRevoked(final Collection<TopicPartition>
partitions, final RebalanceConsumer rebalanceConsumer) {
assertDoesNotThrow(() -> consumer.commitSync(Map.of(tp, new
OffsetAndMetadata(0))));
Review Comment:
`rebalanceConsumer.commitSync`?
##########
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerPollTest.java:
##########
@@ -219,17 +220,19 @@ public void
onPartitionsRevoked(Collection<TopicPartition> partitions) {
consumer.commitSync(offsets);
Review Comment:
`rebalanceConsumer.commitSync(offsets)`?
##########
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##########
@@ -3266,35 +3290,35 @@ private KafkaConsumer<String, String>
consumerWithPendingError(GroupProtocol gro
return consumerWithPendingAuthenticationError(groupProtocol, time);
}
- private ConsumerRebalanceListener getConsumerRebalanceListener(final
KafkaConsumer<?, ?> consumer) {
- return new ConsumerRebalanceListener() {
+ private RebalanceListener getRebalanceListener(final KafkaConsumer<?, ?>
consumer) {
+ return new RebalanceListener() {
@Override
- public void onPartitionsRevoked(Collection<TopicPartition>
partitions) {
+ public void onPartitionsRevoked(Collection<TopicPartition>
partitions, RebalanceConsumer rebalanceConsumer) {
}
@Override
- public void onPartitionsAssigned(Collection<TopicPartition>
partitions) {
+ public void onPartitionsAssigned(Collection<TopicPartition>
partitions, RebalanceConsumer rebalanceConsumer) {
// set initial position so we don't need a lookup
for (TopicPartition partition : partitions)
consumer.seek(partition, 0);
Review Comment:
`rebalanceConsumer.seek()`?
##########
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##########
@@ -2278,23 +2295,24 @@ public void
testClassicConsumerCloseRunsRevocationCallbackAndAttemptsLeaveGroupW
AtomicInteger revokedCount = new AtomicInteger(0);
AtomicReference<Set<TopicPartition>> revokedPartitions = new
AtomicReference<>();
- ConsumerRebalanceListener listener = new ConsumerRebalanceListener() {
+ RebalanceListener listener = new RebalanceListener() {
@Override
- public void onPartitionsRevoked(Collection<TopicPartition>
partitions) {
+ public void onPartitionsRevoked(Collection<TopicPartition>
partitions, RebalanceConsumer rebalanceConsumer) {
assertTrue(Thread.currentThread().isInterrupted());
revokedCount.incrementAndGet();
revokedPartitions.set(Set.copyOf(partitions));
}
@Override
- public void onPartitionsAssigned(Collection<TopicPartition>
partitions) {
+ public void onPartitionsAssigned(Collection<TopicPartition>
partitions, RebalanceConsumer rebalanceConsumer) {
// Preserve the existing helper behavior so assignment setup
remains equivalent.
for (TopicPartition partition : partitions)
consumer.seek(partition, 0);
Review Comment:
`rebalanceConsumer.seek()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]