[ 
https://issues.apache.org/jira/browse/KAFKA-21269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18126467#comment-18126467
 ] 

Chia-Ping Tsai commented on KAFKA-21269:
----------------------------------------

source: https://github.com/apache/kafka/pull/23785/changes#r4248920995

> Add tests for describing broker configs with raw string values
> --------------------------------------------------------------
>
>                 Key: KAFKA-21269
>                 URL: https://issues.apache.org/jira/browse/KAFKA-21269
>             Project: Kafka
>          Issue Type: Test
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>            Priority: Minor
>         Attachments: DescribeBrokerConfigsIntegrationTest.java
>
>
> {code:java}
>     val valueAsString = if (isSensitive)
>       null
>     else value match {
>       case v: String => v
>       case _ => ConfigDef.convertToString(value, configEntryType.orNull)
>     } {code}
> We don’t parse all broker-related values in KafkaConfig. For example, the 
> cluster-wide and prefixed configs. Hence, we catch the “raw string” and then 
> keep it as it is to avoid casting error.
> However, we don’t even have such tests for both cases. #23785 removed the 
> guard and CI was still green. We should add integration tests for describing 
> a cluster-wide LIST config (e.g. {{{}log.cleanup.policy{}}}) and a prefixed 
> LIST config (e.g. {{{}listener.name.external.ssl.enabled.protocols{}}}).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to