Copilot commented on code in PR #23794:
URL: https://github.com/apache/kafka/pull/23794#discussion_r4256414893
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/AssignmentRefinerImpl.java:
##########
@@ -356,6 +390,41 @@ private static Optional<String> bestCopyToPromote(
.map(TaskCopy::memberId);
}
+ /**
+ * The standby task of an orphan that is promoted to run the task although
the coordinator cannot tell how far
+ * behind it is, because its holder does not report its restore progress:
a member that is not
+ * {@link WarmupSupport#SUPPORTED}. Only a standby task that the target
assignment also gives to that member is
+ * promoted.
Review Comment:
This new exception makes two existing contracts inaccurate: `analyzeTasks`
still says only active-running or caught-up copies are promoted (lines
235–239), and `StagedMigration.currentOwner` still describes promoted copy
holders as caught up (lines 1306–1309). Please update both Javadocs to include
this unobservable orphan-standby case so callers do not rely on the old
invariant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
