gaurav-narula commented on code in PR #23785:
URL: https://github.com/apache/kafka/pull/23785#discussion_r4260844112
##########
server/src/main/java/org/apache/kafka/server/ConfigHelperUtils.java:
##########
@@ -72,12 +72,17 @@ public static
DescribeConfigsResponseData.DescribeConfigsResult createResponseCo
// Cast from Map<String, ?> to Map<String, Object> to eliminate
wildcard types. Cached to avoid multiple calls.
@SuppressWarnings("unchecked")
Map<String, Object> nonInternalValues = (Map<String, Object>)
config.nonInternalValues();
+ Map<String, ?> values = config.values();
Stream<Entry<String, Object>> allEntries = Stream.concat(
config.originals().entrySet().stream()
.filter(entry -> entry.getValue() != null
&&
explicitlySetConfigs.contains(entry.getKey())
&&
!nonInternalValues.containsKey(entry.getKey()))
- .map(entry -> Map.entry(entry.getKey(),
entry.getValue())),
+ // Use the parsed value for internal configs, since
createConfigEntry expects values of the
Review Comment:
That's a sharp edge 😬 I tried to see if we could parse the cluster-wise and
prefixed configs but that's not straightforward. Reverted the change for now
and copied the guard from the broker path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
