gaurav-narula commented on code in PR #23779:
URL: https://github.com/apache/kafka/pull/23779#discussion_r4268676542
##########
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##########
@@ -1466,7 +1466,15 @@ private boolean hasValidClusterId(String
requestClusterId) {
if (requestClusterId == null) {
return true;
}
- return clusterId.equals(requestClusterId);
+ if (!clusterId.equals(requestClusterId)) {
Review Comment:
Seems unrelated
##########
clients/src/main/java/org/apache/kafka/common/utils/Time.java:
##########
@@ -115,12 +115,15 @@ default <T> T waitForFuture(
long deadlineNs
) throws TimeoutException, InterruptedException, ExecutionException {
TimeoutException timeoutException = null;
+ long startTimeNs = nanoseconds();
+ long timeoutNs = deadlineNs - startTimeNs;
Review Comment:
I'm now sure how this helps. It seems to me the overflow can only occur when
`deadlineNs` is initialised and looking at the implementation of `Deadline`, it
caps it to `Long.MAX_VALUE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
