muralibasani commented on code in PR #23813:
URL: https://github.com/apache/kafka/pull/23813#discussion_r4275420857


##########
tools/src/main/java/org/apache/kafka/tools/ConsoleProducer.java:
##########
@@ -392,7 +392,9 @@ Properties producerProps() throws IOException {
 
             
props.putAll(parseKeyValueArgs(options.valuesOf(commandPropertyOpt)));
             props.put(BOOTSTRAP_SERVERS_CONFIG, 
options.valueOf(bootstrapServerOpt));
-            props.put(COMPRESSION_TYPE_CONFIG, compressionCodec());
+            if (options.has(compressionCodecOpt) || 
!props.containsKey(COMPRESSION_TYPE_CONFIG)) {
+                props.put(COMPRESSION_TYPE_CONFIG, compressionCodec());

Review Comment:
   How would be the behaviour incase of empty or invalid compression.type ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to