squah-confluent commented on code in PR #23733: URL: https://github.com/apache/kafka/pull/23733#discussion_r4279399328
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/uniform2/KeepStickyExtraPartitions.java: ########## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.coordinator.group.assignor.uniform2; + +import org.apache.kafka.coordinator.group.assignor.uniform2.util.IntList; +import org.apache.kafka.coordinator.group.assignor.uniform2.util.IntPair; + +import java.util.Arrays; + +/** + * The first step deciding the {@link Quotas}: every member owning more than the minimum quota of a + * topic keeps one of its extra partitions, so that it only gives up what it owns beyond its quota. + * When more owners qualify than the topic has extra partitions, the ones with the smallest + * assignments keep them, the assignment sizes counting the extra partitions kept for the previous + * topics, then the members in member order. + */ +final class KeepStickyExtraPartitions { Review Comment: I see. I would still prefer a subpackage -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
