aschmidt402 commented on PR #23338: URL: https://github.com/apache/kafka/pull/23338#issuecomment-6196357543
> Thanks for the patch @aschmidt402! I agree that this is a useful guard. One thing to note is that there is no guarantee that we will make another 3.9.x release. This improvement may never actually get released. > > For the actual change, WDYT about logging vs throwing in this scenario? One concern with just logging during activation is that a user may not realize anything has gone wrong and just continue on forever in the MIGRATION state with ZK brokers. I chose this approach because I was worried that there might be downstream issues with throwing, or cases where having the migration fail would be more cumbersome than letting it go through and then needing to restart brokers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
