AndrewJSchofield commented on code in PR #23665:
URL: https://github.com/apache/kafka/pull/23665#discussion_r4308573983
##########
clients/src/main/java/org/apache/kafka/common/requests/RequestHeader.java:
##########
@@ -137,11 +137,27 @@ public ResponseHeader toResponseHeader() {
return new ResponseHeader(data.correlationId(),
apiKey().responseHeaderVersion(apiVersion()));
Review Comment:
Isn't it theoretically possible that
`apiKey().isVersionSupported(apiVersion())` is false in which case the response
header version is not really known? I suppose the response header version
should be 1 in this case, and we must never add non-tagged fields to the
response header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
