ethanresnick opened a new pull request, #23866: URL: https://github.com/apache/kafka/pull/23866
SaslAuthenticatorFailurePositiveDelayTest sets failedAuthenticationDelayMs to 200, and the teardown asserts that at least that much mock time passed. But createEchoServer calls the NetworkTestUtils overload without a delay, which uses a fixed 100 ms. So the server never applies the configured delay. The assertion passes only because the test reads the MockTime(1) clock enough extra times before the teardown, and each read advances it by 1 ms. SaslAuthenticatorFailureNoDelayTest (delay 0) also gets the 100 ms server delay. Pass failedAuthenticationDelayMs to the overload that takes a delay, so the server applies the delay that each subclass configures. Testing: all 8 tests in SaslAuthenticatorFailurePositiveDelayTest and SaslAuthenticatorFailureNoDelayTest pass on trunk with OpenJDK 21. We found the problem by running these tests on a runtime that reads the clock fewer times on the same path (Java compiled to WebAssembly). There, testInvalidPasswordSaslPlain, testInvalidPasswordSaslScram, and testDisabledSaslMechanism failed with "timeSpent: 193" against the expected 200. Co-Authored-By: Claude Opus 5.5 <[email protected]> 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
