chia7712 commented on code in PR #23662:
URL: https://github.com/apache/kafka/pull/23662#discussion_r4315281770
##########
server/src/main/java/org/apache/kafka/server/config/AbstractKafkaConfig.java:
##########
@@ -104,6 +105,51 @@ public AbstractKafkaConfig(ConfigDef definition, Map<?, ?>
originals, Map<String
super(definition, originals, configProviderProps, doLog);
}
+ public RemoteLogManagerConfig remoteLogManagerConfig() {
+ return new RemoteLogManagerConfig(this);
+ }
+
+ /**
+ * Copy the subset of properties that are relevant to Logs. The individual
properties
+ * are listed here since the names are slightly different in each Config
class...
+ */
+ public Map<String, Object> extractLogConfigMap() {
+ Map<String, Object> logProps = new HashMap<>();
+ logProps.put(TopicConfig.SEGMENT_BYTES_CONFIG, logSegmentBytes());
+ logProps.put(TopicConfig.SEGMENT_MS_CONFIG, logRollTimeMillis());
+ logProps.put(TopicConfig.SEGMENT_JITTER_MS_CONFIG,
logRollTimeJitterMillis());
+ logProps.put(TopicConfig.SEGMENT_INDEX_BYTES_CONFIG,
logIndexSizeMaxBytes());
+ logProps.put(TopicConfig.FLUSH_MESSAGES_INTERVAL_CONFIG,
logFlushIntervalMessages());
+ logProps.put(TopicConfig.FLUSH_MS_CONFIG, logFlushIntervalMs());
+ logProps.put(TopicConfig.RETENTION_BYTES_CONFIG, logRetentionBytes());
+ logProps.put(TopicConfig.RETENTION_MS_CONFIG,
logRetentionTimeMillis());
+ logProps.put(TopicConfig.MAX_MESSAGE_BYTES_CONFIG, messageMaxBytes());
+ logProps.put(TopicConfig.MAX_DECOMPRESSED_MESSAGE_BYTES_CONFIG,
maxDecompressedMessageBytes());
+ logProps.put(TopicConfig.INDEX_INTERVAL_BYTES_CONFIG,
logIndexIntervalBytes());
+ logProps.put(TopicConfig.DELETE_RETENTION_MS_CONFIG,
logCleanerDeleteRetentionMs());
+ logProps.put(TopicConfig.MIN_COMPACTION_LAG_MS_CONFIG,
logCleanerMinCompactionLagMs());
+ logProps.put(TopicConfig.MAX_COMPACTION_LAG_MS_CONFIG,
logCleanerMaxCompactionLagMs());
+ logProps.put(TopicConfig.FILE_DELETE_DELAY_MS_CONFIG,
logDeleteDelayMs());
+ logProps.put(TopicConfig.MIN_CLEANABLE_DIRTY_RATIO_CONFIG,
logCleanerMinCleanRatio());
+ logProps.put(TopicConfig.CLEANUP_POLICY_CONFIG, logCleanupPolicy());
+ logProps.put(TopicConfig.MIN_IN_SYNC_REPLICAS_CONFIG,
minInSyncReplicas());
+ logProps.put(TopicConfig.COMPRESSION_TYPE_CONFIG, compressionType());
+ logProps.put(TopicConfig.COMPRESSION_GZIP_LEVEL_CONFIG,
gzipCompressionLevel());
+ logProps.put(TopicConfig.COMPRESSION_LZ4_LEVEL_CONFIG,
lz4CompressionLevel());
+ logProps.put(TopicConfig.COMPRESSION_ZSTD_LEVEL_CONFIG,
zstdCompressionLevel());
+ logProps.put(TopicConfig.UNCLEAN_LEADER_ELECTION_ENABLE_CONFIG,
uncleanLeaderElectionEnable());
+ logProps.put(TopicConfig.PREALLOCATE_CONFIG, logPreAllocateEnable());
+ logProps.put(TopicConfig.MESSAGE_TIMESTAMP_TYPE_CONFIG,
logMessageTimestampType().name);
+ logProps.put(TopicConfig.MESSAGE_TIMESTAMP_BEFORE_MAX_MS_CONFIG,
logMessageTimestampBeforeMaxMs());
+ logProps.put(TopicConfig.MESSAGE_TIMESTAMP_AFTER_MAX_MS_CONFIG,
logMessageTimestampAfterMaxMs());
+ RemoteLogManagerConfig remoteLogManagerConfig =
remoteLogManagerConfig();
Review Comment:
This micro-optimization could be applied to other methods.
```java
private void validateLogRemoteCopyLagMs(AbstractKafkaConfig newConfig) {
long logRetentionMs = newConfig.logRetentionTimeMillis();
long logLocalRetentionMs =
newConfig.remoteLogManagerConfig().logLocalRetentionMs();
long effectiveLocalRetentionMs = logLocalRetentionMs == -2L ?
logRetentionMs : logLocalRetentionMs;
long logRemoteCopyLagMs =
newConfig.remoteLogManagerConfig().logRemoteCopyLagMs();
```
```java
private void validateLogRemoteCopyLagBytes(AbstractKafkaConfig
newConfig) {
long logRetentionBytes = newConfig.logRetentionBytes();
long logLocalRetentionBytes =
newConfig.remoteLogManagerConfig().logLocalRetentionBytes();
long effectiveLocalRetentionBytes = logLocalRetentionBytes == -2L ?
logRetentionBytes : logLocalRetentionBytes;
long logRemoteCopyLagBytes =
newConfig.remoteLogManagerConfig().logRemoteCopyLagBytes();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
