chickenchickenlove commented on PR #23855: URL: https://github.com/apache/kafka/pull/23855#issuecomment-6292547482
@lucasbru I've pushed a new commit that incorporates most of your suggestions! I left out the `matches()` optimization for now, as I think it would be better to address it in a separate issue. However, if you consider it a minor change, I'm also happy to include it in this PR. Just let me know what you think! I also added a comment at the end of KAFKA-21302. Even when running the exact same code, the ordering of copartition groups can vary across JVM runs if the source nodes are defined using `Set.of(...)`. I wanted to highlight this again, as I thought it might be helpful when determining the priority of this issue. When you get a chance, please take another look! 🙇♂️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
