chia7712 commented on code in PR #23889:
URL: https://github.com/apache/kafka/pull/23889#discussion_r4331954218
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/assignor/RackAwareStandbyPicker.java:
##########
@@ -32,8 +32,8 @@
import java.util.stream.IntStream;
/**
- * Picks the conditions for the next standby of one task: the most tag keys
that a process with room can meet,
- * preferring the keys earlier in {@code rack.aware.assignment.tags}. A
process meets a tag key when it has a value
+ * Picks the conditions for the next standby of one task: the tag keys in
{@code rack.aware.assignment.tags} order, each
+ * kept if a process with room meets it together with those kept so far. A
process meets a tag key when it has a value
Review Comment:
Should we also mention the priority order in
GroupCoordinatorConfig.STREAMS_GROUP_RACK_AWARE_ASSIGNMENT_TAGS_DOC?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
