chia7712 commented on code in PR #23665:
URL: https://github.com/apache/kafka/pull/23665#discussion_r4344738802
##########
clients/src/main/java/org/apache/kafka/common/requests/RequestContext.java:
##########
@@ -191,6 +231,13 @@ public int requestType() {
return header.apiKey().id;
}
+ /**
+ * Returns the original API version sent by the client in the request
header. This can differ from
Review Comment:
```
CreateDelegationTokenResponse.prepareResponse(request.context.requestVersion,
requestThrottleMs,
CreateDelegationTokenResponse.prepareResponse(request.context.requestVersion,
requestThrottleMs,
request.context.requestVersion,
```
I think those parts related to preparing the response should use
effectiveApiVersion instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
