adixitconfluent commented on PR #23892: URL: https://github.com/apache/kafka/pull/23892#issuecomment-6333500865
>I (claude) wrote a test and can see starvation of 1 partition. It was just a matter of sequence of operations that this piece was earlier working, @adixitconfluent correct me if I am wrong, as I do not think we deliberately put the missing partitions prior to already fetched in the response. The problem is a bit deep while updating fetchOffsetMetadata for the partitions. When all fetched records are not sent to client then fetchOffsetMetadata is also bumped for trimmed partitions which extrensically adds the partitions to the missing list. @AndrewJSchofield @adixitconfluent Let me know the choice, I can address that in the same PR or separate PR or prior to current PR (my preference). Yes, while writing the code for `combineLogReadResponse`, I did not really consider starvation but the sequence of operations ensured that there is no starvation and hence we never faced a problem. I think we should fix the problem when all the fetched records are not sent to client then we shouldn't update `fetchOffsetMetadata` for the unsent partitions. I am okay if that is in a separate PR or if you want me to take it up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
