sumanpal97 commented on code in PR #23168:
URL: https://github.com/apache/kafka/pull/23168#discussion_r4347377940


##########
raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java:
##########
@@ -195,6 +197,83 @@ void canElectNewLeaderAfterOldLeaderFailure() {
         });
     }
 
+    @ParameterizedTest
+    @ValueSource(ints = {4, 5, 6, 7, 8, 9})

Review Comment:
   No longer applicable. The simulation test was removed in favour of the unit 
test.
   
   



##########
raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java:
##########
@@ -195,6 +197,83 @@ void canElectNewLeaderAfterOldLeaderFailure() {
         });
     }
 
+    @ParameterizedTest
+    @ValueSource(ints = {4, 5, 6, 7, 8, 9})
+    void preferredSuccessorWinsElectionAfterGracefulLeaderShutdown(int 
numVoters) {
+        Cluster cluster = new Cluster(numVoters, 0, 1234L);
+        /* The other simulations lower this to keep their runtime down, but 
here the whole point is
+         * that the nominated successors stand for election one at a time, so 
use the production
+         * default to keep the gap between them wide enough to be meaningful.
+         */

Review Comment:
   Thanks. Per Kevin's feedback, this simulation test has been removed, so the 
comment is gone too.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to