clolov opened a new pull request, #23912: URL: https://github.com/apache/kafka/pull/23912
This PR moves DynamicRemoteLogConfig from Scala to Java. It now receives the current config and an optional RemoteLogManager instead of the whole KafkaBroker. It also removes the Scala BrokerReconfigurable trait, so the remaining Scala reconfigurables now implement the Java BrokerReconfigurable and take AbstractKafkaConfig. Notes for reviewers: - DynamicListenerConfig casts AbstractKafkaConfig to KafkaConfig, because listeners and effectiveAdvertisedBrokerListeners haven't moved to AbstractKafkaConfig yet. DynamicBrokerConfig only ever passes a KafkaConfig, so the cast can't fail today. It goes away once those accessors move. - remoteLogManagerOpt is read once at registration rather than on each reconfigure. BrokerServer assigns it once, before addReconfigurables, so behaviour is unchanged. - The update log lines for remote log manager config now use the logger org.apache.kafka.server.config.DynamicRemoteLogConfig instead of kafka.server.DynamicRemoteLogConfig. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
