mimaison commented on code in PR #23778:
URL: https://github.com/apache/kafka/pull/23778#discussion_r4349855011
##########
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java:
##########
@@ -2547,6 +2549,33 @@ public void testVoteRequestClusterIdValidation(boolean
withKip853Rpc) throws Exc
context.assertSentVoteResponse(Errors.INCONSISTENT_CLUSTER_ID);
}
+ @Test
+ public void testInconsistentClusterIdLogsComparedClusterIds() throws
Exception {
Review Comment:
Instead of adding a new test, could we capture logs from existing test logic
that expect INCONSISTENT_CLUSTER_ID and check them? That way we'd validate all
these paths.
We can also use `appender.getMessages(Level.WARN)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
