kevin-wu24 commented on PR #23939: URL: https://github.com/apache/kafka/pull/23939#issuecomment-6369792443
Notes for reviewers: - The only conflict was in `RecordsIteratorTest`. This branch still uses jqwik `@Property` tests, so I dropped trunk's indentation-only change to `forCompressionTypeSeed` (that helper doesn't exist here) and added the three new tests between `testFileRecords` and `testCrcValidation`, where they sit on trunk. The rest of the diff matches trunk. - Ran locally on JDK 17: `./gradlew :clients:test --tests 'org.apache.kafka.common.record.*' :raft:test`, plus `checkstyleMain`, `checkstyleTest` and `spotlessCheck` for `clients` and `raft`. All passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
