kuoche1712003 commented on code in PR #22279:
URL: https://github.com/apache/kafka/pull/22279#discussion_r4366467103
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMetadata.java:
##########
@@ -107,6 +107,18 @@ synchronized void clearTransientTopics() {
this.transientTopics.clear();
}
+ /**
+ * Topics this consumer currently needs metadata for: subscribed topics,
topics of assigned
+ * partitions, and transient topics registered temporarily by
offset-related APIs. This is the
+ * same set of topics {@link #retainTopic(String, boolean, long)} keeps,
so a metadata error
+ * about a topic outside this set cannot concern any of this consumer's
pending operations.
+ */
+ public synchronized Set<String> subscribedAssignedAndTransientTopics() {
Review Comment:
Agree, makes sense to consolidate. Let me go through the existing checks and
the regex case and I’ll follow up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
