chungyichi commented on PR #23946:
URL: https://github.com/apache/kafka/pull/23946#issuecomment-6384608623

   Testing:
   - New `ZkMigrationClientTest#testPartitionStateUsesZkControllerEpoch`. The
     harness uses KRaft epoch 42 and ZK epoch 1; the test first claims
     controller leadership so the ZK epoch becomes 2, then asserts that the
     partition state znode's controllerEpoch equals the ZK epoch after
     createTopic, updateTopicPartitions and createTopicPartitions. Without the
     fix it fails with `expected: <2> but was: <42>`.
   - Ran in a JDK 17 container: `kafka.zk.migration.*` and 
`kafka.zk.ZkMigration*`
     (57 tests) pass, plus `:core:checkstyleMain`, `:core:checkstyleTest` and
     `:core:spotlessCheck`. I have not run the full `:core:test` suite.
   
   Notes:
   - Znodes already written with the KRaft epoch by an unpatched controller are
     not repaired by this change; they keep that value until the partition state
     is written again.
   - This targets 3.9 because ZooKeeper and the migration code were removed in 
4.0.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to