squah-confluent commented on code in PR #23923:
URL: https://github.com/apache/kafka/pull/23923#discussion_r4371941197


##########
coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorExecutorImpl.java:
##########
@@ -232,6 +245,39 @@ public void cancelAll() {
         tasks.keySet().forEach(this::cancel);
     }
 
+    /**
+     * Submits the tasks scheduled by the operations in the current batch, now 
that the batch
+     * has been written.
+     */
+    public void onBatchWritten() {

Review Comment:
   You've stumbled upon one of the bugs in 
https://issues.apache.org/jira/browse/KAFKA-20912. It also impacts 
non-replaying operations which update the timeline structures directly.
   
   We haven't decided how to fix it yet. One option could be to drop the 
flush-on-large-batch entirely. Another could be to create a snapshot after each 
append().



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to