apoorvmittal10 commented on PR #23951: URL: https://github.com/apache/kafka/pull/23951#issuecomment-6414599493
> Thanks for the PR. > > One other question. In DelayedShareFetch when combining newly read and already fetched partitions, can the order of the combination adversely affect the fairness? The problem is that for shared partitions you can never guarantee that which partitions attain fetch locks across different clients, when multiple same set of partitions are requested concurrently by different client hence fetch lock acquisition will play a role as well. But the partitions fetch strategy now prioritizes the partitions which went unserved. So I don't think eventually `combine` method will make a difference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
