unknowntpo commented on PR #23357: URL: https://github.com/apache/kafka/pull/23357#issuecomment-6415696613
@lianetm KAFKA-19804 (#23687) is now on trunk and already covers the first heartbeat, so I dropped that case and the dedicated tests. The wait is now asserted at the end of your testHeartbeatNotSentIfAnotherOneInFlight (from KAFKA-16528), where the next heartbeat stays in flight past the interval, plus a small HeartbeatRequestStateTest case. @frankvicky Could you also take a look since you reviewed #23687 ? This covers the later heartbeats that #23687 does not, thanks ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
