[
https://issues.apache.org/jira/browse/KAFKA-21365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ziyun Fu reassigned KAFKA-21365:
--------------------------------
Assignee: Ziyun Fu (was: Chia-Ping Tsai)
> Add separate test file to ensure the three deprecated subscribe methods are
> covered
> ------------------------------------------------------------------------------------
>
> Key: KAFKA-21365
> URL: https://issues.apache.org/jira/browse/KAFKA-21365
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Chia-Ping Tsai
> Assignee: Ziyun Fu
> Priority: Major
>
> we are migrating to the new listener, but the deprecated methods still need
> to be tested. Hence, it would be good to have a separate test file for them
> to convince us that it is ok to migrate 🙂
> The three methods are:
> * subscribe(Collection, ConsumerRebalanceListener)
> * subscribe(Pattern, ConsumerRebalanceListener)
> * subscribe(SubscriptionPattern, ConsumerRebalanceListener)
> The test should verify the 1-arg callbacks are invoked on a real consumer for
> both CLASSIC and CONSUMER protocols (SubscriptionPattern is CONSUMER only),
> and that a null listener throws IllegalArgumentException.
> clients-integration-tests is a good place for it.
> Also, this file can be removed in 5.0 directly. Clear and safe
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
