smjn commented on code in PR #23964:
URL: https://github.com/apache/kafka/pull/23964#discussion_r4381805075
##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -774,17 +777,28 @@ class BrokerServer(
}
}
+ /** Daemon thread factory naming each thread with the given name. */
+ private def daemonThreadFactory(threadName: String): ThreadFactory = {
+ (runnable: Runnable) => {
+ val thread = new Thread(runnable, threadName)
+ thread.setDaemon(true)
+ thread
+ }
+ }
+
private def createShareGroupDLQManager(): ShareGroupDLQManager = {
val className = config.shareGroupConfig.shareGroupDLQManagerClassName
if (className.nonEmpty) {
if (className.equals(classOf[DefaultShareGroupDLQManager].getName)) {
+ shareGroupDLQFetchExecutor =
Executors.newSingleThreadExecutor(daemonThreadFactory("share-group-dlq-record-fetcher"))
Review Comment:
will add a new internal config for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
