lucasbru commented on code in PR #23803:
URL: https://github.com/apache/kafka/pull/23803#discussion_r4387807989
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfigTest.java:
##########
@@ -445,21 +448,21 @@ public void
testStreamsGroupAssignorsWithDuplicateNamesFails() {
}
@Test
- public void testStreamsGroupAssignorsWithReservedBuiltinNameFails() {
- // A custom assignor must not take the name of a built-in, whether or
not the built-in is
- // itself configured: a group selecting that name would otherwise
silently get the custom one.
+ public void testStreamsGroupAssignorsOverridingBuiltinName() {
Review Comment:
This lines streams up with what da078363444 (KAFKA-20843) did for consumer
groups. That commit left the streams check strict on purpose, and said whether
the strict rule should come back could be revisited for 4.5. @mjsax are you
fine with dropping it for streams too, so that a custom assignor can override a
built-in by name?
##########
docs/getting-started/upgrade.md:
##########
@@ -26,6 +26,14 @@ type: docs
-->
+## Upgrading to 4.5.0
+
+### Upgrading Servers to 4.5.0 from any version 3.3.x through 4.4.0
Review Comment:
nit: this subsection is empty. Also, the note below is mostly about the name
override. Should the new `balanced` assignor get its own line, perhaps also in
the 4.5.0 section of the streams upgrade guide? Streams users are more likely
to look there.
##########
docs/streams/developer-guide/streams-rebalance-protocol.md:
##########
@@ -39,7 +39,7 @@ The following features are available in the current release:
* **Core Streams Group Rebalance Protocol**: The `group.protocol=streams`
configuration enables the dedicated streams rebalance protocol. This separates
streams groups from consumer groups and provides a streams-specific group
membership lifecycle and metadata management on the broker.
-* **Sticky Task Assignor**: A basic task assignment strategy that minimizes
task movement during rebalances is included. It is registered under the name
`sticky` and is the default assignor.
+* **Built-in Task Assignors**: Two task assignment strategies are included.
The `sticky` assignor minimizes task movement during rebalances and is the
default assignor. The `balanced` assignor spreads the tasks of each subtopology
across processes and evens out the per-thread task load, at the price of moving
more tasks when the group membership changes; it is the counterpart of the
`HighAvailabilityTaskAssignor` of the classic protocol, without warmup tasks,
which are not an assignor feature in the streams protocol, and without
rack-aware placement, which neither built-in assignor implements yet. A group
selects an assignor with the group configuration `streams.assignor.name`.
* **Custom Task Assignors**: Brokers can be configured with custom task
assignors via `group.streams.assignors`, which takes a list of built-in
assignor names and fully qualified class names of custom `TaskAssignor`
implementations. The first entry is the default assignor. An individual group
selects one of the registered assignors by name with the group configuration
`streams.assignor.name`; when unset, the group uses the first entry of
`group.streams.assignors`. Custom implementations must be thread-safe, since a
single instance is shared across all groups on a broker.
Review Comment:
nit: maybe mention here as well that a custom assignor can reuse a built-in
name and then replaces that built-in. Right now that's only in the upgrade
notes.
##########
docs/streams/developer-guide/streams-rebalance-protocol.md:
##########
@@ -39,7 +39,7 @@ The following features are available in the current release:
* **Core Streams Group Rebalance Protocol**: The `group.protocol=streams`
configuration enables the dedicated streams rebalance protocol. This separates
streams groups from consumer groups and provides a streams-specific group
membership lifecycle and metadata management on the broker.
-* **Sticky Task Assignor**: A basic task assignment strategy that minimizes
task movement during rebalances is included. It is registered under the name
`sticky` and is the default assignor.
+* **Built-in Task Assignors**: Two task assignment strategies are included.
The `sticky` assignor minimizes task movement during rebalances and is the
default assignor. The `balanced` assignor spreads the tasks of each subtopology
across processes and evens out the per-thread task load, at the price of moving
more tasks when the group membership changes; it is the counterpart of the
`HighAvailabilityTaskAssignor` of the classic protocol, without warmup tasks,
which are not an assignor feature in the streams protocol, and without
rack-aware placement, which neither built-in assignor implements yet. A group
selects an assignor with the group configuration `streams.assignor.name`.
Review Comment:
not sure why we need to mention rack-awareness at all at this stage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]