chia7712 commented on code in PR #23988:
URL: https://github.com/apache/kafka/pull/23988#discussion_r4394183775
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -583,6 +583,22 @@ public class StreamsConfig extends AbstractConfig {
public static final String DEFAULT_VALUE_SERDE_CLASS_CONFIG =
"default.value.serde";
private static final String DEFAULT_VALUE_SERDE_CLASS_DOC = "Default
serializer / deserializer class for value that implements the
<code>org.apache.kafka.common.serialization.Serde</code> interface. ";
+ /** {@code default.list.key.serde.inner} */
+ @SuppressWarnings("WeakerAccess")
+ public static final String DEFAULT_LIST_KEY_SERDE_INNER_CLASS =
CommonClientConfigs.DEFAULT_LIST_KEY_SERDE_INNER_CLASS;
Review Comment:
Should we follow the naming convention by adding the `_CONFIG` suffix?
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
Review Comment:
Should we update this
`CommonClientConfigs#BOOTSTRAP_RESOLVE_TIMEOUT_MS_CONFIG` as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
