muralibasani commented on code in PR #23859:
URL: https://github.com/apache/kafka/pull/23859#discussion_r4394092411
##########
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/DescribeConfigsTest.java:
##########
@@ -76,4 +84,41 @@ public void
testDescribeConfigsTopicWithInternalListConfig(ClusterInstance clust
assertEquals("0:101", entry.value());
}
}
+
+ // Cluster-wide configs are described from
DynamicBrokerConfig#currentDynamicDefaultConfigs, which holds raw
+ // strings. A LIST config must be returned as the raw string instead of
being cast to a List.
+ @ClusterTest
+ public void testDescribeConfigsClusterWideListConfig(ClusterInstance
cluster) throws Exception {
+ ConfigResource clusterResource = new
ConfigResource(ConfigResource.Type.BROKER, "");
+ try (Admin admin = cluster.admin()) {
+ admin.incrementalAlterConfigs(Map.of(clusterResource, List.of(new
AlterConfigOp(
+ new ConfigEntry(ServerLogConfigs.LOG_CLEANUP_POLICY_CONFIG,
"compact,delete"),
+ AlterConfigOp.OpType.SET)))).all().get();
+ TestUtils.waitForCondition(() -> {
Review Comment:
nit: thinking instead of waitForCondition retrying on any exception, how
about waiting only for the source to propagate? A regression would then fail
immediately with a clear diff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
