squah-confluent commented on code in PR #23723:
URL: https://github.com/apache/kafka/pull/23723#discussion_r4402068345
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/uniform2/Quotas.java:
##########
@@ -131,6 +138,15 @@ public int assignmentSize(int member) {
return minAssignmentSizes[group.cohortOf(member)] +
extraPartitionCounts[member];
}
+ /**
+ * @return An upper bound of the number of topics of which the member gets
partitions. A topic
+ * with a minimum quota above 0 counts twice when the member gets
one of its extra
+ * partitions.
+ */
+ public int maxTopicsWithPartitions(int member) {
+ return topicsWithMinQuotaAboveZero[group.cohortOf(member)] +
extraPartitionCounts[member];
+ }
Review Comment:
Isn't the new sizing too small for the very first assignor run now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
