gabriellefu commented on code in PR #23588:
URL: https://github.com/apache/kafka/pull/23588#discussion_r4404739409
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/assignor/StickyTaskAssignor.java:
##########
@@ -433,7 +450,7 @@ private static Member findPrevMemberWithLeastLoad(
for (final Member member : members) {
final ProcessState processState =
localState.processIdToState.get(member.processId);
// A process that already owns a standby task (either as active or
standby) cannot take it again
- if (standbyTaskId.isPresent() &&
processState.hasTask(standbyTaskId.get())) {
+ if (standbyTaskId.isPresent() &&
processState.hasTask(standbyTaskId.get()) ||
!prevMemberCondition.test(processState)) {
Review Comment:
Split into two continue checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
