unknowntpo commented on PR #23895: URL: https://github.com/apache/kafka/pull/23895#issuecomment-6484007482
Note: the same rule, `min(min.insync.replicas, replica count of the partition)`, is now computed in three places: broker: `Partition#effectiveMinIsr` controller: `ReplicationControlManager#getEffectiveMinIsr` (this PR) cli: `TopicCommand#minIsrCount` for `--under-min-isr-partitions` and `--at-min-isr-partitions` (#24005) This PR only adds a comment so the controller stays in sync with the broker. All three modules depend on `server-common`, so a follow-up could move the rule into one shared helper there. I can open a JIRA for it if that sounds reasonable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
