lucasbru commented on code in PR #24003:
URL: https://github.com/apache/kafka/pull/24003#discussion_r4410289673
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManagerTest.java:
##########
@@ -2487,6 +2487,68 @@ public void testIsGroupReadyChangeWhenTasksAreNull() {
completeAssignment(tasksAssignedEvent2);
}
+ @Test
+ public void testAssignmentDelayedKeepsReadyGroupReady() {
Review Comment:
Agreed, both are worth pinning down. Added
`testAssignmentDelayedWhileReconcilingKeepsTargetReady` /
`...KeepsTargetNotReady` for the pending-callback case in both directions (both
fail if the readiness is taken from `currentAssignment`), and
`testAssignmentDelayedWithUnchangedAssignmentKeepsStableMemberReady` for the
echoed assignment while `STABLE`, which also fails without the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
