chia7712 commented on code in PR #23981:
URL: https://github.com/apache/kafka/pull/23981#discussion_r4414245039
##########
tests/kafkatest/tests/streams/streams_application_upgrade_test.py:
##########
@@ -31,7 +31,7 @@
str(LATEST_3_4), str(LATEST_3_5), str(LATEST_3_6),
str(LATEST_3_7), str(LATEST_3_8), str(LATEST_3_9),
str(LATEST_4_0), str(LATEST_4_1), str(LATEST_4_2),
- str(LATEST_4_3)]
+ str(LATEST_4_3), str(LATEST_4_4)]
# The headers-aware suppress buffer (KAFKA-20413) is only on trunk, so 4.3 is
the newest
Review Comment:
Could you update this comment?
```
# The headers-aware suppress buffer (KAFKA-20413) shipped in 4.4.0, so 4.3
is the newest
# release that still writes plain V3 suppress-changelog records even with
this config set.
```
##########
tests/kafkatest/tests/streams/streams_broker_compatibility_test.py:
##########
@@ -25,7 +25,7 @@
)
from kafkatest.services.verifiable_consumer import VerifiableConsumer
from kafkatest.version import LATEST_3_0, LATEST_3_1, LATEST_3_2, LATEST_3_3,
LATEST_3_4, LATEST_3_5, LATEST_3_6, \
- LATEST_3_7, LATEST_3_8, LATEST_3_9, LATEST_4_0, LATEST_4_1, LATEST_4_2,
LATEST_4_3, DEV_BRANCH, KafkaVersion
+ LATEST_3_7, LATEST_3_8, LATEST_3_9, LATEST_4_0, LATEST_4_1, LATEST_4_2,
LATEST_4_3, LATEST_4_4, DEV_BRANCH, KafkaVersion
Review Comment:
We need to add `LATEST_4_4` to `version.py`
```
# 4.4.x version
V_4_4_0 = KafkaVersion("4.4.0")
LATEST_4_4 = V_4_4_0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
