suzhiking commented on code in PR #23899:
URL: https://github.com/apache/kafka/pull/23899#discussion_r4418495792
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -316,6 +316,20 @@ private static UpdateTargetAssignmentResult<Assignment>
fromLastTargetAssignment
}
}
+ /**
+ * The result of updating a streams group's target assignment.
+ *
+ * @param targetAssignmentEpoch The target assignment epoch.
+ * @param targetAssignment All members' target assignments.
+ * @param members The members the target assignment is keyed
by: the group's members with the
+ * unwritten membership change of the
heartbeat applied.
+ */
+ private record UpdateStreamsTargetAssignmentResult(
+ int targetAssignmentEpoch,
+ Map<String, TasksTuple> targetAssignment,
+ Map<String, StreamsGroupMember> members
+ ) { }
+
Review Comment:
that would be cleaner, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
