harmadasg commented on PR #24018: URL: https://github.com/apache/kafka/pull/24018#issuecomment-6509326552
@omkreddy thanks for the review! I only had minor conflicts in the test code: - import conflict with `ByteUtils`. It lives in `org.apache.kafka.common.utils` on 3.9 vs `org.apache.kafka.common.utils.internals` on trunk (MessageTest, RequestHeaderTest, ProtocolSerializationTest) - testReadCompactArraySizeTooLarge uses try/fail on 3.9 but assertThrows on trunk trunk commits for reference: - https://github.com/apache/kafka/commit/ea1f10a7130 - https://github.com/apache/kafka/commit/d89cb613d0 - https://github.com/apache/kafka/commit/3316389b05 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
