mjsax commented on code in PR #23262:
URL: https://github.com/apache/kafka/pull/23262#discussion_r4419403640
##########
clients/src/main/java/org/apache/kafka/common/requests/StreamsGroupHeartbeatResponse.java:
##########
@@ -119,5 +121,13 @@ public static Status fromCode(byte code) {
}
return status;
}
+
+ public static boolean isKnownCode(byte code) {
Review Comment:
Not sure about this -- in the end, if we get an invalid code, and we want to
fail, throwing is the right thing -- the problem we are fixing with this PR is,
that the exception gets incorrectly swallowed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
