mjsax commented on PR #24020: URL: https://github.com/apache/kafka/pull/24020#issuecomment-6528105943
> is there ever a case where we'd want to use the partition from the record metadata? If yes then we'd check first if it's -1. > But I'm thinking it would end up being the same so I'm guessing not, just wanted to ask for confirmation. You are right. There is no such case. In the regular case, both should be the same (otherwise there is a bug). In the end, we want to encode the left hand side partition, to tell the right hand side where to send the response. So using `task().partition()` is always correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
