Parkerhiphop opened a new pull request, #24048:
URL: https://github.com/apache/kafka/pull/24048

   As mentioned in 
https://github.com/apache/kafka/pull/22017#discussion_r4429568025, the 
class-level `@Timeout` on these test classes is redundant.
   
   JUnit resolves a method-level `@Timeout` before the class-level one, and a 
class-level `@Timeout` only applies to test methods that have no timeout of 
their own.
   
   `@ClusterTest`, `@ClusterTests` and `@ClusterTemplate` are meta-annotated 
with `@Timeout(60)`, so each cluster test method effectively carries a 
method-level timeout.
   
   The changed test classes only contain cluster test methods, so I removed the 
redundant `@Timeout` from them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to