chia7712 commented on code in PR #24066:
URL: https://github.com/apache/kafka/pull/24066#discussion_r4438177600
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfigManager.java:
##########
@@ -118,6 +118,7 @@ public boolean isDlqAutoTopicCreateEnabled() {
/**
* Remove all group configs.
*/
+ @Override
Review Comment:
This close method is somewhat unusual to me. First, the benefit from it is
trivial. Second, `BrokerServer` closes the `groupConfigManager` before
`groupCoordinator`. If it is indeed used to release resources, the order would
cause a bug, I guess.
```java
if (groupConfigManager != null)
Utils.swallow(this.logger.underlying, () =>
groupConfigManager.close())
if (groupCoordinator != null)
Utils.swallow(this.logger.underlying, () =>
groupCoordinator.shutdown())
```
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfigManager.java:
##########
@@ -118,6 +118,7 @@ public boolean isDlqAutoTopicCreateEnabled() {
/**
* Remove all group configs.
*/
+ @Override
Review Comment:
We will file a patch to either fix the order or, preferably, strip
`AutoCloseable` from `GroupConfigManager`. @dajac If the interface is
intentional, please let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
