NicoleYWDu commented on PR #24071:
URL: https://github.com/apache/kafka/pull/24071#issuecomment-6568753587
Note for reviewers: KIP-1388 is still under discussion. This PR is a draft
so the implementation can be reviewed in parallel with the KIP. It should
not be merged until the vote passes.
One decision worth confirming: ListGroups v6 is not marked
`latestVersionUnstable` because it is fully implemented in this PR. If you
prefer to gate the version until the KIP is accepted, that is a one-line
change.
Testing:
- `RequestResponseTest`: v6 serialization round trip via the all-versions
loop; `testListGroupRequestV5FailsWithRequireCommittedOffsets` and
`testListGroupRequestV5SucceedsWithoutRequireCommittedOffsets`.
- `OffsetMetadataManagerTest`: `testHasCommittedOffsets` (uncommitted write
not visible, visible after commit, gone after tombstone) and
`testHasCommittedOffsetsIgnoresPendingTransactionalOffsets` (pending only
is excluded, included after COMMIT marker).
- `GroupCoordinatorShardTest`: filter applied when the flag is set; offsets
manager not consulted when it is not.
- `GroupCoordinatorServiceTest`: the flag is forwarded to the shard.
- `ListGroupsOptionsTest`: setter, getter, default, and factory interaction.
- `KafkaAdminClientConsumerGroupTest`: happy path, v5-only broker fails
`all()` with `UnsupportedVersionException` and reports it in `errors()`,
and a two-broker mixed-version case where `valid()` holds only the
supporting broker's groups.
- `ListGroupsRequestTest` (core, integration): classic and consumer groups
with and without offsets, AND with the types filter, group drops out after
OffsetDelete; streams group with a committed offset is returned; share
group is listed without the flag and never with it.
Ran on the final tree:
./gradlew spotlessCheck clients:checkstyleMain clients:checkstyleTest \
group-coordinator:checkstyleMain group-coordinator:checkstyleTest \
core:checkstyleMain core:checkstyleTest
./gradlew clients:test --tests ListGroupsOptionsTest \
--tests KafkaAdminClientConsumerGroupTest --tests RequestResponseTest
./gradlew group-coordinator:test --tests GroupCoordinatorShardTest \
--tests GroupCoordinatorServiceTest --tests OffsetMetadataManagerTest \
--tests GroupMetadataManagerTest
./gradlew core:test --tests kafka.server.ListGroupsRequestTest \
--tests kafka.server.KafkaApisTest
1494 tests, 0 failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
