dejan2609 commented on code in PR #23073: URL: https://github.com/apache/kafka/pull/23073#discussion_r4445005088
########## README.md: ########## @@ -306,7 +306,7 @@ These take the same arguments as the built-in variants. The following options should be set with a `-P` switch, for example `./gradlew -PmaxParallelForks=1 test`. * `commitId`: sets the build commit ID as .git/HEAD might not be correct if there are local commits added for build purposes. -* `mavenUrl`: sets the URL of the maven deployment repository (`file://path/to/repo` can be used to point to a local repository). +* `mavenUrl`: sets the URL of the Maven deployment repository (`file:///absolute/path/to/repo` can be used to point to a local repository). Review Comment: Hi @dino2895 and sorry for the delay. I confirmed it works: `./gradlew -PmavenUrl=file:///tmp/maven-test-repo :clients:publishMavenJavaPublicationToMavenRepository` succeeds. However, I think it goes a bit further than the ticket needs. In the[ Jira comment ](https://issues.apache.org/jira/browse/KAFKA-20853?focusedId=18099763&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-18099763) @chia7712 suggested: ``` I think we could just remove the comment "// To test locally, invoke gradlew with `-PmavenUrl=file:///some/local/path`", since we could leverage `publishToMavenLocal` instead` ``` That leaves us with these two cases: 1. **local publishing** --> `./gradlew publishToMavenLocal`, which works as expected on both trunk and this PR 2. **remote publishing** --> `-PmavenUrl=...` + credentials (used by `release.py`) So my suggestion would be to reduce this PR to: - `build.gradle`: remove the `// To test locally ...` comment and keep the `publishing {}` block as in trunk - `README.md`: update the `mavenUrl` entry, for example: - describe it as the URL of the **remote** Maven repository - mention `publishToMavenLocal` as the way to publish locally - drop the `file:///absolute/path/to/repo` hint - `api-checker/build.gradle`: no change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
