jolshan commented on code in PR #24092:
URL: https://github.com/apache/kafka/pull/24092#discussion_r4483436742
##########
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionMarkerChannelManagerTest.scala:
##########
@@ -400,6 +400,70 @@ class TransactionMarkerChannelManagerTest {
assertEquals(Map(broker1 -> expectedBroker1Request), secondDrainedRequests)
}
+ @ParameterizedTest
+ @EnumSource(classOf[TransactionResult])
+ def shouldRetryMarkersUntilLeaderEndpointIsAvailable(result:
TransactionResult): Unit = {
+ mockCache()
+ txnMetadata2.state(if (result == TransactionResult.COMMIT)
TransactionState.PREPARE_COMMIT else TransactionState.PREPARE_ABORT)
+ val expectedTransition = txnMetadata2.prepareComplete(time.milliseconds())
+ // Return noNode for addTxnMarkersToSend, and the first two
generateRequests()
+ when(metadataCache.getPartitionLeaderEndpoint(
+ ArgumentMatchers.eq(partition1.topic),
+ ArgumentMatchers.eq(partition1.partition),
+ any())
+ ).thenReturn(Optional.of(Node.noNode))
+ .thenReturn(Optional.of(Node.noNode))
+ .thenReturn(Optional.of(Node.noNode))
+ .thenReturn(Optional.of(broker1)
+ )
Review Comment:
I can try that approach. It just seemed like all the other caches were
mocked. So I would have to create a real cache here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
