jolshan commented on code in PR #24114:
URL: https://github.com/apache/kafka/pull/24114#discussion_r4484417227
##########
core/src/main/scala/kafka/coordinator/transaction/TransactionMarkerRequestCompletionHandler.scala:
##########
@@ -91,115 +91,125 @@ class TransactionMarkerRequestCompletionHandler(brokerId:
Int,
val writeTxnMarkerResponse =
response.responseBody.asInstanceOf[WriteTxnMarkersResponse]
val responseErrors = writeTxnMarkerResponse.errorsByProducerId
+ var firstException: Exception = null
for (pendingCompleteTxnAndMarker <-
pendingCompleteTxnAndMarkerEntries.asScala) {
- val pendingCompleteTxn = pendingCompleteTxnAndMarker.pendingCompleteTxn
- val transactionalId = pendingCompleteTxn.transactionalId
- val txnMarker = pendingCompleteTxnAndMarker.txnMarkerEntry
- val errors = responseErrors.get(txnMarker.producerId)
+ try {
+ val pendingCompleteTxn =
pendingCompleteTxnAndMarker.pendingCompleteTxn
+ val transactionalId = pendingCompleteTxn.transactionalId
+ val txnMarker = pendingCompleteTxnAndMarker.txnMarkerEntry
+ val errors = responseErrors.get(txnMarker.producerId)
- if (errors == null)
- throw new IllegalStateException(s"WriteTxnMarkerResponse does not
contain expected error map for producer id ${txnMarker.producerId}")
+ if (errors == null)
+ throw new IllegalStateException(s"WriteTxnMarkerResponse does not
contain expected error map for producer id ${txnMarker.producerId}")
- txnStateManager.getTransactionState(transactionalId) match {
- case Left(Errors.NOT_COORDINATOR) =>
- info(s"I am no longer the coordinator for $transactionalId; cancel
sending transaction markers $txnMarker to the brokers")
+ txnStateManager.getTransactionState(transactionalId) match {
+ case Left(Errors.NOT_COORDINATOR) =>
+ info(s"I am no longer the coordinator for $transactionalId;
cancel sending transaction markers $txnMarker to the brokers")
- txnMarkerChannelManager.removeMarkersForTxn(pendingCompleteTxn)
+ txnMarkerChannelManager.removeMarkersForTxn(pendingCompleteTxn)
- case Left(Errors.COORDINATOR_LOAD_IN_PROGRESS) =>
- info(s"I am loading the transaction partition that contains
$transactionalId which means the current markers have to be obsoleted; " +
- s"cancel sending transaction markers $txnMarker to the brokers")
+ case Left(Errors.COORDINATOR_LOAD_IN_PROGRESS) =>
+ info(s"I am loading the transaction partition that contains
$transactionalId which means the current markers have to be obsoleted; " +
+ s"cancel sending transaction markers $txnMarker to the
brokers")
- txnMarkerChannelManager.removeMarkersForTxn(pendingCompleteTxn)
+ txnMarkerChannelManager.removeMarkersForTxn(pendingCompleteTxn)
- case Left(unexpectedError) =>
- throw new IllegalStateException(s"Unhandled error $unexpectedError
when fetching current transaction state")
+ case Left(unexpectedError) =>
+ throw new IllegalStateException(s"Unhandled error
$unexpectedError when fetching current transaction state")
- case Right(None) =>
- throw new IllegalStateException(s"The coordinator still owns the
transaction partition for $transactionalId, but there is " +
- s"no metadata in the cache; this is not expected")
+ case Right(None) =>
+ throw new IllegalStateException(s"The coordinator still owns the
transaction partition for $transactionalId, but there is " +
+ s"no metadata in the cache; this is not expected")
- case Right(Some(epochAndMetadata)) =>
- val txnMetadata = epochAndMetadata.transactionMetadata
- val retryPartitions: mutable.Set[TopicPartition] =
mutable.Set.empty[TopicPartition]
- var abortSending: Boolean = false
+ case Right(Some(epochAndMetadata)) =>
+ val txnMetadata = epochAndMetadata.transactionMetadata
+ val retryPartitions: mutable.Set[TopicPartition] =
mutable.Set.empty[TopicPartition]
+ var abortSending: Boolean = false
- if (epochAndMetadata.coordinatorEpoch !=
txnMarker.coordinatorEpoch) {
- // coordinator epoch has changed, just cancel it from the
purgatory
- info(s"Transaction coordinator epoch for $transactionalId has
changed from ${txnMarker.coordinatorEpoch} to " +
- s"${epochAndMetadata.coordinatorEpoch}; cancel sending
transaction markers $txnMarker to the brokers")
+ if (epochAndMetadata.coordinatorEpoch !=
txnMarker.coordinatorEpoch) {
+ // coordinator epoch has changed, just cancel it from the
purgatory
+ info(s"Transaction coordinator epoch for $transactionalId has
changed from ${txnMarker.coordinatorEpoch} to " +
+ s"${epochAndMetadata.coordinatorEpoch}; cancel sending
transaction markers $txnMarker to the brokers")
- txnMarkerChannelManager.removeMarkersForTxn(pendingCompleteTxn)
- abortSending = true
- } else {
- txnMetadata.inLock(() => {
- for ((topicPartition, error) <- errors.asScala) {
- error match {
- case Errors.NONE =>
- txnMetadata.removePartition(topicPartition)
-
- case Errors.CORRUPT_MESSAGE |
- Errors.MESSAGE_TOO_LARGE |
- Errors.RECORD_LIST_TOO_LARGE |
- Errors.INVALID_REQUIRED_ACKS => // these are all
unexpected and fatal errors
-
- throw new IllegalStateException(s"Received fatal error
${error.exceptionName} while sending txn marker for $transactionalId")
-
- case Errors.UNKNOWN_TOPIC_OR_PARTITION |
- Errors.NOT_LEADER_OR_FOLLOWER |
- Errors.NOT_ENOUGH_REPLICAS |
- Errors.NOT_ENOUGH_REPLICAS_AFTER_APPEND |
- Errors.REQUEST_TIMED_OUT |
- Errors.KAFKA_STORAGE_ERROR => // these are retriable
errors
-
- info(s"Sending $transactionalId's transaction marker for
partition $topicPartition has failed with error ${error.exceptionName},
retrying " +
- s"with current coordinator epoch
${epochAndMetadata.coordinatorEpoch}")
-
- retryPartitions += topicPartition
-
- case Errors.INVALID_PRODUCER_EPOCH |
- Errors.TRANSACTION_COORDINATOR_FENCED => // producer
or coordinator epoch has changed, this txn can now be ignored
-
- info(s"Sending $transactionalId's transaction marker for
partition $topicPartition has permanently failed with error
${error.exceptionName} " +
- s"with the current coordinator epoch
${epochAndMetadata.coordinatorEpoch}; cancel sending any more transaction
markers $txnMarker to the brokers")
-
-
txnMarkerChannelManager.removeMarkersForTxn(pendingCompleteTxn)
- abortSending = true
-
- case Errors.UNSUPPORTED_FOR_MESSAGE_FORMAT |
- Errors.UNSUPPORTED_VERSION =>
- // The producer would have failed to send data to the
failed topic so we can safely remove the partition
- // from the set waiting for markers
- info(s"Sending $transactionalId's transaction marker
from partition $topicPartition has failed with " +
- s" ${error.name}. This partition will be removed from
the set of partitions" +
- s" waiting for completion")
- txnMetadata.removePartition(topicPartition)
-
- case other =>
- throw new IllegalStateException(s"Unexpected error
${other.exceptionName} while sending txn marker for $transactionalId")
+ txnMarkerChannelManager.removeMarkersForTxn(pendingCompleteTxn)
+ abortSending = true
+ } else {
+ txnMetadata.inLock(() => {
+ for ((topicPartition, error) <- errors.asScala) {
+ error match {
+ case Errors.NONE =>
+ txnMetadata.removePartition(topicPartition)
+
+ case Errors.CORRUPT_MESSAGE |
+ Errors.MESSAGE_TOO_LARGE |
+ Errors.RECORD_LIST_TOO_LARGE |
+ Errors.INVALID_REQUIRED_ACKS => // these are all
unexpected and fatal errors
+
+ throw new IllegalStateException(s"Received fatal error
${error.exceptionName} while sending txn marker for $transactionalId")
+
+ case Errors.UNKNOWN_TOPIC_OR_PARTITION |
+ Errors.NOT_LEADER_OR_FOLLOWER |
+ Errors.NOT_ENOUGH_REPLICAS |
+ Errors.NOT_ENOUGH_REPLICAS_AFTER_APPEND |
+ Errors.REQUEST_TIMED_OUT |
+ Errors.KAFKA_STORAGE_ERROR => // these are
retriable errors
+
+ info(s"Sending $transactionalId's transaction marker
for partition $topicPartition has failed with error ${error.exceptionName},
retrying " +
+ s"with current coordinator epoch
${epochAndMetadata.coordinatorEpoch}")
+
+ retryPartitions += topicPartition
+
+ case Errors.INVALID_PRODUCER_EPOCH |
+ Errors.TRANSACTION_COORDINATOR_FENCED => //
producer or coordinator epoch has changed, this txn can now be ignored
+
+ info(s"Sending $transactionalId's transaction marker
for partition $topicPartition has permanently failed with error
${error.exceptionName} " +
+ s"with the current coordinator epoch
${epochAndMetadata.coordinatorEpoch}; cancel sending any more transaction
markers $txnMarker to the brokers")
+
+
txnMarkerChannelManager.removeMarkersForTxn(pendingCompleteTxn)
+ abortSending = true
+
+ case Errors.UNSUPPORTED_FOR_MESSAGE_FORMAT |
+ Errors.UNSUPPORTED_VERSION =>
+ // The producer would have failed to send data to the
failed topic so we can safely remove the partition
+ // from the set waiting for markers
+ info(s"Sending $transactionalId's transaction marker
from partition $topicPartition has failed with " +
+ s" ${error.name}. This partition will be removed
from the set of partitions" +
+ s" waiting for completion")
+ txnMetadata.removePartition(topicPartition)
+
+ case other =>
+ throw new IllegalStateException(s"Unexpected error
${other.exceptionName} while sending txn marker for $transactionalId")
+ }
}
- }
- })
- }
+ })
+ }
- if (!abortSending) {
- if (retryPartitions.nonEmpty) {
- debug(s"Re-enqueuing ${txnMarker.transactionResult}
transaction markers for transactional id $transactionalId " +
- s"under coordinator epoch ${txnMarker.coordinatorEpoch}")
-
- // re-enqueue with possible new leaders of the partitions
- txnMarkerChannelManager.addTxnMarkersToBrokerQueue(
- txnMarker.producerId,
- txnMarker.producerEpoch,
- txnMarker.transactionResult,
- pendingCompleteTxn,
- retryPartitions.toSet)
- } else {
-
txnMarkerChannelManager.maybeWriteTxnCompletion(transactionalId)
+ if (!abortSending) {
+ if (retryPartitions.nonEmpty) {
+ debug(s"Re-enqueuing ${txnMarker.transactionResult}
transaction markers for transactional id $transactionalId " +
+ s"under coordinator epoch ${txnMarker.coordinatorEpoch}")
+
+ // re-enqueue with possible new leaders of the partitions
+ txnMarkerChannelManager.addTxnMarkersToBrokerQueue(
+ txnMarker.producerId,
+ txnMarker.producerEpoch,
+ txnMarker.transactionResult,
+ pendingCompleteTxn,
+ retryPartitions.toSet)
+ } else {
+
txnMarkerChannelManager.maybeWriteTxnCompletion(transactionalId)
+ }
}
- }
+ }
+ } catch {
+ case e: Exception =>
+ error(s"Failed to handle WriteTxnMarkers response for
transactional id
${pendingCompleteTxnAndMarker.pendingCompleteTxn.transactionalId} " +
+ s"and marker ${pendingCompleteTxnAndMarker.txnMarkerEntry};
continuing with the remaining entries", e)
+ if (firstException == null) firstException = e else
firstException.addSuppressed(e)
Review Comment:
When we add suppressed, we will just have a chain of exceptions -- the first
one just being the one that was processed first?
Do we have a test for that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]