jolshan commented on code in PR #21735:
URL: https://github.com/apache/kafka/pull/21735#discussion_r4498739485
##########
transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionMetadata.java:
##########
@@ -332,8 +419,8 @@ private TxnTransitMetadata
prepareTransitionTo(TransitionData data) {
// check that the new state transition is valid and update the pending
state if necessary
if (data.state.validPreviousStates().contains(this.state)) {
TxnTransitMetadata transitMetadata = new TxnTransitMetadata(
- data.producerId, this.producerId, data.nextProducerId,
data.producerEpoch, data.lastProducerEpoch,
- data.txnTimeoutMs, data.state, data.topicPartitions,
+ data.producerId, data.prevProducerId, data.nextProducerId,
data.producerEpoch, data.lastProducerEpoch,
Review Comment:
Is the change from `this.producerId` to `data.prevProducerId` required
because of the possibility for more bumps or is this change more just to
simplify this line of code to refer to purely the data object?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
