smjn commented on code in PR #24106:
URL: https://github.com/apache/kafka/pull/24106#discussion_r4513441335
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -5910,7 +5898,14 @@ public CoordinatorResult<Void, CoordinatorRecord>
initializeShareGroupState(
if (topicPartitionMap == null || topicPartitionMap.isEmpty()) {
return new CoordinatorResult<>(List.of(), null);
}
- ShareGroup group = (ShareGroup) groups.get(groupId);
+ ShareGroup group;
+ try {
+ group = shareGroup(groupId);
Review Comment:
@muralibasani No, because a deleteGroup wipes the partitionMetadata record
on the group coordinator side which means all the initializing/initialized info
is gone.
Now when a new group with same name is created - it re-initialized an builds
partitionMetadata again so previous share group's state is never re-used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]